hotfix: TUP-714 news list page links not working

[wesleyboar]

Overview

Use link.getAttribute('href') not link.href, so isAbsolute is not true for News list "Previous" and "Next" links.

Warning

There is still the problem of the code link.href = link.pathname; which would remove URL parameters, but at least the "Previous" and "next" links are being properly ignored now.

Related

• TUP-714
• required by hotfix: tup-714 News "Previous" & "Next" links not working + v4.10 tup-ui#451

Changes

• changed link.getAttribute('href') not link.href in setTargetForExternalLinks.js

Testing

1. Use the new file on a news page with pagination.
   • A. Load a page with News on which you've added enough articles.
     ^{To create less articles, set pagination threshold to be very small.}
   • B. Edit same file on tup_cms container directly while running https://github.com/TACC/tup-ui.
2. Verify "Previous" or "Next" links work.

UI

Script	Page

test.mov