Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: TV3-181/cmd-79 change FAVICON & LOGO prefix #795

Merged
merged 1 commit into from
Feb 8, 2024
Merged

feat: TV3-181/cmd-79 change FAVICON & LOGO prefix #795

merged 1 commit into from
Feb 8, 2024

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Feb 8, 2024 •
edited
Loading

Overview / Changes

Change prefixes on renamed settings.

Before After
TACC_FAVICON
TACC_LOGO		 PORTAL_FAVICON
PORTAL_LOGO

Related

Testing

  1. Build new CMS image.
  2. Update Core-Portal-Deployments to use new prefix for PTDataX.
  3. Deploy PTDataX Pre-Prod.
  4. Verify logo and favicon are unchanged / still work.

UI

pprd ptdatax

@wesleyboar wesleyboar requested a review from taoteg February 8, 2024 19:36
taoteg
taoteg approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wesleyboar wesleyboar mentioned this pull request Feb 8, 2024
Merged
4 tasks
@wesleyboar wesleyboar merged commit fecdc93 into main Feb 8, 2024
@wesleyboar wesleyboar deleted the feat/TV3-181-cmd-79-rename-favicon-and-logo-from-tacc-to-portal branch February 8, 2024 21:02
This was referenced Feb 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taoteg taoteg taoteg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wesleyboar @taoteg