Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: setting paths example-cms should be example_cms #749

Merged

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Nov 20, 2023

Overview

Setting paths example-cms should be example_cms.

Background

Migration Django 4 → Core-CMS 3.12 replaced Python names' "-" with "_".

The incorrect path makes Core-CMS-Resources example assets fail to load.

Related

None.

Changes

  • change example customs settings asset paths from example_cms to example_cms

Testing

  1. Load app using settings.custom.py with example-cms asset paths (v4.1.0 tag).
  2. Open CMS website.
  3. Verify logos do not load.
  4. Load app using settings.custom.py with example_cms asset paths (this branch).
  5. Refresh CMS website.
  6. Verify logos do load.

UI

Before After
before after

Migration Django 4 → Core-CMS 3.12 replaced Python names' "-" with "_".

The incorrect path makes Core-CMS-Resources example assets fail to load.
@wesleyboar wesleyboar merged commit 9a15aed into main Nov 20, 2023
@wesleyboar wesleyboar deleted the hotfix/example-cms-paths-assume-dash-isntead-of-underscore branch November 20, 2023 16:52
@wesleyboar wesleyboar added the bug Something isn't working label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant