Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: tup-638 "share this" can show w/out icons #739

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Nov 1, 2023

Overview

Do not render "share this:" if TACC_SOCIAL_SHARE_PLATFORMS array is empty.

Related

Changes

  • moved block render into a conditional

Testing & UI

Skipped.

@wesleyboar wesleyboar marked this pull request as ready for review November 1, 2023 17:12
@wesleyboar wesleyboar merged commit f3e7016 into main Nov 1, 2023
@wesleyboar wesleyboar deleted the hotfix/tup-638-social-media-sharing-without-icons branch November 1, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant