Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/tup-634: Migrate pseudo-elements to core-cms #738

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

R-Tomas-Gonzalez
Copy link
Collaborator

Overview

Migrate pseudo-elements to core-cms.

Related

Changes

  • Added folder for generics
  • Added pseudo-element to generic folder

Testing

Use the target pseudo-element on a div to see the interaction

Screenshot 2023-10-24 at 5 14 00 PM

UI

Screenshot 2023-10-24 at 5 27 27 PM

@R-Tomas-Gonzalez R-Tomas-Gonzalez added migrate css to core Migration of CSS to Core-CMS or Core-Styles feature A new feature or replacement of present feature labels Oct 24, 2023
Copy link
Member

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Almost done.

Single change request.

@wesleyboar
Copy link
Member

P.S. I know the focus outline does not show above the section being focused. That's a bug I am not sure how to fix. (I think I'd need to add margin atop cols, but then I have to do other stuff to prevent changes to negative space across the website.) Ideas welcome.

@wesleyboar wesleyboar merged commit 80ff00c into main Nov 6, 2023
@wesleyboar wesleyboar deleted the feat/tup-634-migrate-pseudo-elements branch November 6, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature or replacement of present feature migrate css to core Migration of CSS to Core-CMS or Core-Styles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants