Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: deprecated node version & install script #712

Closed
wants to merge 1 commit into from
Closed

refactor: deprecated node version & install script #712

wants to merge 1 commit into from

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Sep 11, 2023 •
edited
Loading

Status

Note
Replaced by #741.

Overview

  1. Install Node the new way, to avoid artificial 20 second delay in build.
  2. Update Node version to current LTS (our current version is EOL).

Build Core_CMS_Build #1247 reported both a (version) "DEPRECATION WARNING" and a "SCRIPT DEPRECATION WARNING". The former has been occurring, but the latter is new.

Related

None

Changes

  • changed Dockerfile commands to install Node

Testing

  1. make build
  2. make start
  3. Set up site (follow README).
  4. Load site.
  5. Every step should occur as it has.

UI

Skipped.

@wesleyboar wesleyboar changed the title refactor: update node version Dockerfile install refactor: update node version and method of install Sep 11, 2023
@wesleyboar wesleyboar changed the title refactor: update node version and method of install refactor: deprecated node version & install script Sep 11, 2023
taoteg
taoteg approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@wesleyboar
Copy link
Member Author

Replaced by #741.

@wesleyboar wesleyboar closed this Nov 13, 2023
@wesleyboar wesleyboar deleted the refactor/node-18-and-via-new-install-method branch November 13, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taoteg taoteg taoteg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wesleyboar @taoteg