Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ui demo, and make it an opt-in feature #705

Closed
wants to merge 12 commits into from

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Aug 28, 2023

Overview / Changes

UI Demo:

  • becomes dev feature in Core CMS
  • becomes opt-in feature for client CMS
  • renamed to ui-demo (not css-demo)
  • documented as all the above

Important
Closed, because it adds too much time to client build.

Related

Testing

  1. Build fresh local Core CMS.
  2. Build demo:
    docker exec -it core_cms /bin/bash
    # That opens a command prompt within the container.
        npm run build:ui-demo
  3. Give server time to auto-restart.
  4. Open demo:
    http://localhost:8000/static/ui/index.html
  5. Visit CMS pattern, like Django Forms:
    http://localhost:8000/static/ui/components/detail/django-cms-forms.html
  6. Verify form is styled.

UI

Local Core (TACC/Core-CMS) - Manual Demo Build Local Client (TACC/tup-ui) - Opt-In Demo Build
local via client
Remote Client (dev.tup.tacc…) - Opt-In Demo Build Remote Client (dev.cep.tacc…) - No Demo Build
remote remote core

@wesleyboar
Copy link
Member Author

This adds too much time to the client build.

I think there is a better way to not build for every CMS, but also cache the demo (perhaps isolate its build).

@wesleyboar wesleyboar closed this Aug 28, 2023
@wesleyboar wesleyboar deleted the feat/make-pattern-library-opt-in branch November 13, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant