Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: set SESSION_COOKIE_SECURE = True (off of v3.9.4) #702

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

wesleyboar
Copy link
Member

Overview

Sets SESSION_COOKIE_SECURE = True to resolve a flag set by an ISO security audit.

Related

Testing

  1. In the chrome devtools, go to Application -> Cookies -> and ensure that the "Secure" column for the "sessionid" cookie is checked. See screenshot below

UI

Screenshot 2023-08-22 at 9 37 19 AM

Co-authored-by: Sal Tijerina <r.sal.tijerina@gmail.com>
@wesleyboar
Copy link
Member Author

Approving based on #695.

@wesleyboar wesleyboar changed the base branch from release/v3.9.4 to release/v3.9.5 August 22, 2023 23:32
@wesleyboar wesleyboar merged commit 0fa88dd into release/v3.9.5 Aug 22, 2023
@wesleyboar wesleyboar deleted the fix/3.9.4--session-cookie-secure branch August 22, 2023 23:33
@wesleyboar wesleyboar changed the title hotfix: set SESSION_COOKIE_SECURE = True (off of v3.9.5) hotfix: set SESSION_COOKIE_SECURE = True (off of v3.9.4) Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant