Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not serve ui demo unless it exists #688

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Aug 17, 2023

Overview

Do not serve UI Pattern Library unless its directory exists.

Because https://github.com/TACC/Core-CMS-Custom apps typically do not sync UI demo.1

Status

Core-CMS Build: https://jenkins01.tacc.utexas.edu/job/Core_CMS_Build/1212
Core-CMS-Custom Build: …
Deploy: …

Related

Changes

  • changes settings.py to not serve /static/ui unless taccsite_ui exists

Testing & UI

TACC/Core-CMS-Custom#175

Footnotes

  1. https://github.com/TACC/Core-CMS-Custom will probably not serve UI demo until that demo can auto-import their custom stylesheet.

@wesleyboar wesleyboar changed the title fix: do not server ui demo unless it exists fix: do not serve ui demo unless it exists Aug 18, 2023
@wesleyboar wesleyboar marked this pull request as ready for review August 18, 2023 16:22
@wesleyboar wesleyboar merged commit a32b3a0 into main Aug 18, 2023
@wesleyboar wesleyboar deleted the fix/v3.12.0-alpha.10-crash-in-client-cuz-ui-demo branch August 18, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant