Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: render/style responsive video/audio player (off of v3.11.4) #684

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Aug 15, 2023

Overview

Support responsive embed of a podcast (or any audio or video).

Related

Changes

  • added site.v3-11-plus.css
    to load existing …/django-cms-video.css
  • added link to site.v3-11-plus.css
    in taccsite_cms/templates/assets_site.html

Testing

  1. Create/Open a test page.
    If deployed to Texascale, you may use https://prod.texascale.tacc.utexas.edu/testing/wes-test/?edit.
  2. Add a "Video player" plugin instance.
    Field Value
    TEMPLATE: Responsive Automatic
    LABEL: Podcast
    EMBED LINK: https://w.soundcloud.com/player/?url=https%3A//api.soundcloud.com/tracks/1242255460
  3. Save plugin instance.
  4. Verify podcast:
    • renders
    • stretches to fit available horizontal space
    • is not cut off
    • is functional

UI

Staging Test

Add Podcast Render Podcast
1 pprd add 2 pprd render

Localhost Test

Add Podcast Render Podcast
1 test add plugin 2 test render plugin

Proof of Concept

Archived
Add Podcast Before New Styles After New Styles
1 add podcast, like normal 2 no styles, nothing renders 3 add styles, it renders

@wesleyboar wesleyboar changed the title fix(taccsite_custom): wrong pointer in v3.11.3 (#668) feat: responsive video/audio player (off of v3.11.4) Aug 15, 2023
@wesleyboar wesleyboar changed the title feat: responsive video/audio player (off of v3.11.4) fix: render/style responsive video/audio player (off of v3.11.4) Aug 15, 2023
@wesleyboar wesleyboar marked this pull request as ready for review August 15, 2023 17:39
@wesleyboar wesleyboar merged commit 64f8d73 into release/v3.11.5 Aug 15, 2023
@wesleyboar wesleyboar deleted the feat/support-podcasts branch August 15, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant