Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): anchor around image not supporting margin #670

Merged

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jul 12, 2023

Overview

Make anchor that wraps image have excepted block behavior without losing inherit inline behavior.

Related

Changes

  • added rule to use inline-block layout for a.img-fluid

Testing / UI

See result of the style applied to https://www.tacc.utexas.edu/research/scivis-gallery/ via TACC/tup-ui visualization-gallery-styles. If style is removed (via editing live markup), layout looses good space between items.

@wesleyboar wesleyboar changed the title fix(css): image-wrapping anchor not support margin fix(css): anchor around image not supporting margin Jul 12, 2023
@wesleyboar wesleyboar merged commit 7b51038 into main Jul 12, 2023
@wesleyboar wesleyboar deleted the fix/tup-491-image-wrapping-anchor-should-be-inline-block branch July 12, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant