Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/FP-1499: CMS pattern library #512

Closed
wants to merge 37 commits into from

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jul 12, 2022

Overview

  1. Add UI Pattern Demo using Fractal.
  2. Host UI Pattern Demo at configurable URL.
    ⚠️ New solution required. URL would not be configurable. See sub-branch and TACC/Core-Portal#677 comment.

Related

Changes

add pattern demo
  • chore(git): add & ignore taccsite_ui/ for demo files
  • docs(readme): demo instructions
  • docs(readme): npm link + ui demo warning ← might have solution
  • chore(bin): build css paths using new path util
  • feat(ui): fractal config file
  • feat(package): install fractal
  • feat(package): install core-styles@0.8.0-beta
  • feat(package): split build script into :css and :demo
host at cms url
  • feat(cms): ui demo path
  • feat(cms): ui demo url

Testing

  1. npm ci
  2. npm run build --project=core-cms
    (requires a project e.g. core-cms, frontera-cms, texascale-org)

UI

Screenshots
pprd.ecep dev.cep
ecep, primary cep, primary
ecep, secondary cep, secondary
ecep, tertiary cep, tertiary
ecep, small cep, small

Notes

Known Issues

  1. 🥺 The URL /ui-patterns/ does not load.
  2. 🙁 To develop locally and facilitate testing is cumbersome (and requires #520).
  3. ❓ Frontera servers redirect /ui-patterns/index.html to /ui-patterns/index.html/.
  4. ⚠️ Servers with this code occasionally did not load pages or styles.
    The error is FATAL: remaining connection slots are reserved for non-replication superuser connections. Maybe because Django urls.py change.

This is needed for buttons to appear right on CMS.

Source: #498
Use the new styles context format to load styles for Fractal.
Status (Fail):
```
Core-CMS git:(task/fp-1499-cms-pattern-library) ✗ npm run build:demo

> @TACC/core-cms@3.7.11 build:demo
> fractal build-project $npm_config_project

Warning: command named "info" was registered more than once.
If you intend to override a command, you should explicitly remove the first command with command.remove().
[...]
```
Do not create project CSS path in 2 locations of fractal config. Just 1.
@wesleyboar wesleyboar force-pushed the task/fp-1499-cms-pattern-library branch 3 times, most recently from 03c0845 to e160bc0 Compare July 17, 2022 22:30
@wesleyboar wesleyboar force-pushed the task/fp-1499-cms-pattern-library branch from e160bc0 to 8ff3185 Compare July 18, 2022 00:38
@wesleyboar wesleyboar marked this pull request as ready for review July 18, 2022 22:16
So I can make changes but still pin to latest without publishing to npm.
So reviewers can test without local cms+styles dev setup.

I tested. This works from
- Core-Styles (no npx link)
- Core-Workspaces (w/ npx link)
@rstijerina rstijerina changed the title Task/fp 1499 cms pattern library task/FP-1499: CMS pattern library Jul 25, 2022
@wesleyboar
Copy link
Member Author

Closing in favor of #527.

@wesleyboar wesleyboar closed this Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant