-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task/FP-1499: CMS pattern library #512
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To Do: - add CMS-specific styles - polish?
- one source-of-truth fix for `src/src/…` paths - fix unnoticed broken 'static.path'
The colors are also added in #498.
This was referenced Jul 12, 2022
This is needed for buttons to appear right on CMS. Source: #498
Use the new styles context format to load styles for Fractal.
Status (Fail): ``` Core-CMS git:(task/fp-1499-cms-pattern-library) ✗ npm run build:demo > @TACC/core-cms@3.7.11 build:demo > fractal build-project $npm_config_project Warning: command named "info" was registered more than once. If you intend to override a command, you should explicitly remove the first command with command.remove(). [...] ```
This reverts commit d01e064.
Do not create project CSS path in 2 locations of fractal config. Just 1.
03c0845
to
e160bc0
Compare
e160bc0
to
8ff3185
Compare
Skip loading base component stylsheets because we load site.css. Includes new core-styles version, whcih adds shouldSkipBase prop.
The 0.7.0 did not support pattern demo.
1 task
So I can make changes but still pin to latest without publishing to npm.
So reviewers can test without local cms+styles dev setup. I tested. This works from - Core-Styles (no npx link) - Core-Workspaces (w/ npx link)
This was referenced Jul 25, 2022
Closing in favor of #527. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Related
Changes
add pattern demo
taccsite_ui/
for demo filescore-styles@0.8.0-beta
:css
and:demo
host at cms url
Testing
npm ci
npm run build --project=core-cms
(requires a project e.g.
core-cms
,frontera-cms
,texascale-org
)UI
https://dev.fronteraweb.tacc.utexas.edu/ui-patterns/index.html¹³https://pprd.frontera-portal.tacc.utexas.edu/ui-patterns/index.html¹³Screenshots
Notes
Known Issues
/ui-patterns/
does not load./ui-patterns/index.html
to/ui-patterns/index.html/
.The error is
FATAL: remaining connection slots are reserved for non-replication superuser connections
. Maybe because Djangourls.py
change.