Bugfix/fp 1542 do not use a2cps url

[wesleyboar]

Overview

Use local images for Data Transfer guides.

Related

• FP-1542
• requires fix(fp-1542): figure img margin for link img's too Core-Styles#25

Changes

• [fix] add and use images
• [enhancement] add extra example images I found
• [fix] tweak image max-width

Testing

Confirm images:

• are not loaded from a2cps-staging
• are not wider than the image max width*
• are not excessively large
• are not rendered larger than intrinsic dimensions†

_{* The default guide max image width is 800px, but Data Transfer page sets 670px max image width.
† Some of the images are just bad quality.}

Remote

• https://dev.cep.tacc.utexas.edu/guides/data-transfer-guide/
• https://dev.cep.tacc.utexas.edu/guides/globus-data-transfer-guide/

_{build job & deploy job}

Local

1. Be able to Test CMS Changes.
   • remember to collectstatic (to provide the local images to Django)
2. Add page/s set to use these templates:
   • "Guide: Globus Data Transfer"
   • "Guide: Data Transfer"

Screenshots

Data Transfer	Globus Data Transfer

Notes

✓ To Do

• Generice-ize images. b16bb9f
• Create ticket for more changes. FP-1676

[wesleyboar]

Notes for reviewers.

[wesleyboar]

Explanation. Image text in Data Transfer's bottom-most image was easier to read if a bit larger.

[wesleyboar]

Note for reviewer since updated core-styles commit.

[wesleyboar]

Explanation. To get fix from TACC/Core-Styles#25.

[taoteg]

Would it be useful to scrub (or blur) the A2CPS from the paths in these images and replace it with {PROJECT}, so as not to confuse anyone referencing them?

• https://github.com/TACC/Core-CMS/pull/493/files#diff-4732bdc6c23df3069a4813d513406393610d216e79e26ff47ac29be80cc2dc66
• https://github.com/TACC/Core-CMS/pull/493/files#diff-3a5845b5aa10048e9dc314818891f3682af364686db06fbd4e14969a23710105

A similar concern with the right-side of this image:

• ...e_cms/static/site_cms/img/guides/data_transfer.globus/step-2f-select-system.png

Otherwise, LGTM as far as functional changes go.
Approving as is, up to you on the above concerns.

It would be ideal if we had fresh clean screens from a dummy user actually setting everything up on current systems... but that's probably a bridge too far at this time. Maybe in the v3 iteration. =)

[wesleyboar]

Test URLs fixed:

• https://dev.cep.tacc.utexas.edu/guides/data-transfer-guide/
• https://dev.cep.tacc.utexas.edu/guides/globus-data-transfer-guide/

_{These will be good unless I need to deploy something else to dev.cep and am too lazy to create a branch with multiple features.}

[fnets]

LGTM! Great job, this looks a lot cleaner. Personally, I guess I'd prefer that the guide be a little more portal-agnostic like John said. But, I think that's outside the scope for this particular ticket.

[wesleyboar]

I just read those suggestions. Sounds good. I'll come back to it this week.

[taoteg]

Preface: This all looks great and I don't know if this is in the scope of this PR, but...

While comparing the Data Transfer Guide to the Globus Guide, I noticed that only the images in the Data Transfer Guide have indentation. Could we either A) make all guide images left-aligned or B) make all the guide images centered, with the outcome in either choice being consistent design across both the guides?

I would vote for option B (tweak the Globus Guide layout to match the Data Transfer Guide layout by using centered images).

[wesleyboar]

It is out of scope for this bug fix, but there's also some typography bothering Hedda and I, so I want to add some miscellaneous updates in a follow-up ticket; I'll add your image alignment notes to it.

[wesleyboar]

Images have had project names blurred out (b16bb9f).¹ I have not re-deployed.

Image alignment has been added to new ticket for Guide page inconsistencies: FP-1676. An existing ticket will add breadcrumbs: FP-1452.²

Footnotes

1. Replacing specific project name with {PROJECT} proved difficult to do attractively (match unknown font, fit in narrow gap). ↩

2. Non-crucial changes are low priority, because these Guides pages are supposed to be moved out to TUP documentation (or that's what I remember from a documentation meeting this year). But I do want to improve consistency, and needed to create a ticket for things I've noticed. ↩