Update submodule to include APCD #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyboar
reviewed
May 11, 2022
There was a problem hiding this comment.
Your goal to get the latest APCD stuff succeeded.
But, I found some APCD files that create unnecessary maintenance.
- Replace calls to custom templates in custom settings with:
('standard.html', 'Standard'), ('fullwidth.html', 'Full Width'), - (unless you are migrating APCD from CEPv1) Delete apcd-cms/static/apcd-cms/css/src/_migrations/v1_v2/a2cps.css.
- (unless you are migrating APCD from CEPv1) Delete apcd-cms/static/apcd-cms/css/src/migrate.v1_v2.css.
- (unless you are migrating APCD from CEPv1) Delete apcd-cms/templates/assets_custom.html.
- Delete apcd-cms/templates/fullwidth.html.
- Delete apcd-cms/templates/standard.html.
|
Re-reviewing because of new commit made while I was adding review that I had already sent you privately. 😅 |
wesleyboar
approved these changes
May 11, 2022
There was a problem hiding this comment.
I added another submod commit (18b0a38, which brings in TACC/Core-CMS-Resources@5aaf79b fix).
wesleyboar
added a commit
that referenced
this pull request
Jun 23, 2022
* Update submodule to get apcd directory * Update taccsite_custom submodule to remove unnecessary templates * quick(apcd): ubdate submod Co-authored-by: Wesley Bomar <wbomar@tacc.utexas.edu>
Merged
wesleyboar
added a commit
that referenced
this pull request
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Update taccsite_custom submodule to include apcd-cms
Related
Changes
Update taccsite_custom submodule
Testing
Screenshots
…