Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix: Fix Branding Links not Opening in New Window #397

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Hotfix: Fix Branding Links not Opening in New Window #397

merged 2 commits into from
Nov 4, 2021

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Nov 4, 2021 •
edited
Loading

Overview

Fix typo (age unknown) in Core that preventing branding links from opening in new window (without JavaScript*).

This was noticed on Brainmap, but affects all CMS's.

* Some CMS's has a JavaScript snippet that incidentally, dynamically fixes this.

Changes

  • Fix typo so that target attribute renders value from settings.

Testing

Remote

  1. Open https://pprd.frontera-portal.tacc.utexas.edu/.
  2. Ensure branding bar links open in new window when clicked normally.

Local

  1. Know how to Test CMS Changes.

  2. Load up CMS using Frontera's settings.custom.py (because it meets requirements).

    Requirements
    • value of 3rd entry in array is external link
    • value of 4th entry in array is "_blank"

  3. Confirm that rendered link has target="_blank"

@wesleyboar wesleyboar added the priority ▼ Low priority label Nov 4, 2021
@wesleyboar wesleyboar changed the title Hotfix: Fix target attribute was not working Hotfix: Fix Branding Links not Opening in New Window Nov 4, 2021
taoteg
taoteg approved these changes Nov 4, 2021
View reviewed changes
Copy link
Collaborator

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy Peasy.

@wesleyboar wesleyboar merged commit dd64632 into main Nov 4, 2021
@wesleyboar wesleyboar deleted the hotfix/branding-external-links-open-in-new-window branch November 4, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taoteg taoteg taoteg approved these changes

@rstijerina rstijerina rstijerina approved these changes

@duckonomy duckonomy Awaiting requested review from duckonomy

Assignees
No one assigned
Labels
priority ▼ Low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wesleyboar @taoteg @rstijerina