task/FP-1260 Rename Component ReadMore to ShowMore #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamkwon97
changed the title
wesleyboar
requested changes
Oct 6, 2021
There was a problem hiding this comment.
Please also rename "references in comments." — FP-1260
I see at least five:
- three in docblock at top of file
- two at
/* Read More / Read Less */
wesleyboar
reviewed
Oct 6, 2021
taccsite_cms/static/site_cms/css/src/_imports/components/c-read-more.css
Outdated
Show resolved
Hide resolved
wesleyboar
reviewed
Oct 6, 2021
taccsite_cms/static/site_cms/css/src/_imports/components/c-read-more.css
Outdated
Show resolved
Hide resolved
…d-more.css Co-authored-by: W. Bomar <62723358+tacc-wbomar@users.noreply.github.com>
…d-more.css Co-authored-by: W. Bomar <62723358+tacc-wbomar@users.noreply.github.com>
wesleyboar
requested changes
Oct 6, 2021
duckonomy
approved these changes
Oct 6, 2021
I thought about that too, but I guess it matter haha 😅 |
wesleyboar
approved these changes
Oct 8, 2021
|
Sorry for the late merge. I had no obstacle; I accidentally neglected it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Rename .c-read-more to .c-show-more.
Related Jira tickets:
Summary of Changes:
.c-read-moreto.c-show-moreTesting Steps:
.c-read-morein codebase and check if it changed to.c-show-moreUI Photos:
Notes: