Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing error on login when already logged in #356

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Fixing error on login when already logged in #356

merged 1 commit into from
Sep 23, 2021
+4 −0

Conversation

xandroc
Copy link
Contributor

@xandroc xandroc commented Sep 23, 2021

No description provided.

@xandroc xandroc requested a review from wesleyboar September 23, 2021 17:29
wesleyboar
wesleyboar reviewed Sep 23, 2021
View reviewed changes
Copy link
Member

@wesleyboar wesleyboar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Major typo changed intended meaning. Please see corrected comment.]

@wesleyboar
Copy link
Member

wesleyboar commented Sep 23, 2021 •
edited
Loading

I could not reproduce problem locally on main. I am trying to test this solution on UTRC pprd server, but hit a wall (my fault, unexpected CSS build failure).

If you've already tested successfully that this fixes the problem locally, please let me know.

@xandroc
Copy link
Contributor Author

xandroc commented Sep 23, 2021

I could not reproduce problem locally on main. I am trying to test this solution on UTRC pprd server, but hit a wall (my fault, unexpected CSS build failure).

If you've already tested successfully that this fixes the problem locally, please let me know.

yes, I tested this locally and reproduced the error and verified the fix

@xandroc xandroc merged commit a705d3b into main Sep 23, 2021
@wesleyboar wesleyboar deleted the rochaa/double-login-error branch November 4, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleyboar wesleyboar wesleyboar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xandroc @wesleyboar