Revert "Merge pull request #189 from TACC/task/FP-982" #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Declined. The problem is ES authentication. This was a temp "fix", and it not helpful for Core nor Neuronex, which had a different problem and solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Remove code (that re-indexes search on page publish, un-publish, and delete) until we can find a solution to the real problem.
Background
PR #189 was well-tested locally. But upon its deploy to ProTX—and possibly to Core and Neuronex, so suggests Sal's experience which matches John and Wes' on ProTX—it caused 500 errors on attempts to publish. Those 500 errors came from Elastic Search authentication issue. When, on ProTX server, John fixed some mistyped ES credentials in
secrets.py, the problem still existed. After hunting ES-related changes, PR #189 seemed most likely to trigger the issue. When that "trigger" code was removed, the problem (500s) went away.