-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings changes to make search indexing work #169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description is poorly written. The PR description does not offer enough information.
And, I think the test failed.
What Should I Test?
- The changes don't break anything, and the search behavior does not change.
- Moving
aldryn_apphooks_config
out of blog features makes sense. Thank you. - The rest looks good, but what (current/future) problem are the new settings solving?
Based on Message That Led Me to PR…
I made a PR with some settings tweaks that should make cms content (not just titles) indexable in search.
— Slack message
The CMS already searches "content (not just titles)", even before this PR:
- First, I tested successfully on
conf/make-searchable
using these steps:- TACC/Core-CMS wiki "Test CMS Changes"
- TACC/Core-Portal wiki "How to Build Search Index"
- Search for text that is only in page content, not page title.
- But, I also tested successfully on
master
using the same steps. - Finally, I tested successfully on production Frontera search.
Branches & CMS Images
conf/make-searchable
branch via CMS imagetaccwma/frontera-cms:64b2049
main
branch via CMS imagetaccwma/core-cms:af6d75c
After Guesswork & Hunting Down Sprint Ticket FP-983
Perhaps I should test that both kinds of body content are searched:
Text Added via CMS "Text" Plugin:
- Add Text plugin with text "Alabama" to a page "Bob" (with no prior mention of "Alabama").
- Publish change to page Bob.
- Reindex CMS.
- Search "Alabama".
- ✓ Search results show "Alabama" from Text on page Bob.
Text Hard-Coded into Template:
-
Remove all plugins from page Home.
-
Add template with hard-coded text to CMS secrets.
Code
_CMS_TEMPLATES = ( # … ('guides/data_transfer.html', 'Guide: Data Transfer'), )
-
Set page Home template to "Guide: Data Transfer".
-
Publish change to page Home.
-
Reindex CMS.
-
Search "Transfer".
-
✕ Search results are empty
- Expectation: Search results show "Transfer" from body content on page Bob.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though
The CMS already searches "content (not just titles)", even before this PR
@rstijerina confirms that this is the goal of this PR. I confirm that the content is searched.
Approving.
Need to set up Aldryn so that searchable text shows up when crawling the database for CMS plugins.