Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight Active Link Even For Redirect Pages #56

Closed
wesleyboar opened this issue Jan 21, 2021 · 1 comment
Closed

Highlight Active Link Even For Redirect Pages #56

wesleyboar opened this issue Jan 21, 2021 · 1 comment
Assignees
@wesleyboar
Labels
bug Something isn't working paused Started but not actively in progress priority ▼ Low priority

Comments

@wesleyboar
Copy link
Member

wesleyboar commented Jan 21, 2021 •
edited
Loading

In GitLab by @tacc-wbomar on Dec 1, 2020, 12:47

Summary

Menu link for the active page is not highlighted if link is a redirect to current page.

Steps

  1. Have a page (A) (which is configured to show in "Menu") that redirects to a page (B).
  2. Have a page (B) (which is configured to show in "Menu") that does not redirect.
  3. Load:
    1. any page, except page (B), that shows page (A) in navigation.
    2. page (B) which shows page (A) in navigation.

Expected Result

  1. Page (A) in navigation is not highlighted.
  2. Page (A) in navigation is highlighted.

Actual Result

  1. Page (A) in navigation is not highlighted.
  2. Page (A) in navigation is not highlighted.

Background

On https://texascale.org/, all navigation elements are page redirects, so no link is ever highlighted.

Reference
@wesleyboar wesleyboar added bug Something isn't working label: doing paused Started but not actively in progress priority ▼ Low priority labels Jan 21, 2021
@wesleyboar wesleyboar self-assigned this Jan 21, 2021
wesleyboar added a commit that referenced this issue Apr 22, 2021
@wesleyboar
Merge branch 'main' into bugfix/GH-56-highlight-active-redirect-link
7e4abb4
wesleyboar added a commit that referenced this issue Jun 17, 2021
@wesleyboar
Merge branch 'main' into bugfix/GH-56-highlight-active-redirect-link
e72e327
wesleyboar added a commit that referenced this issue Jul 9, 2021
@wesleyboar
GH-245/GH-56: Move migration styles to submodule
abc1456
wesleyboar added a commit that referenced this issue Jul 9, 2021
@wesleyboar
GH-245/GH-56: Try to avoid server crash
e8d864e 
Avoid this error that occurred on A2CPS

```
AttributeError: module 'taccsite_custom._shared' has no attribute 'default_app_config'
```

via Core-Portal-Deployments 91966f8.
wesleyboar added a commit that referenced this issue Jul 9, 2021
@wesleyboar
GH-245/GH-56: Try to avoid server crash (new way)
9502d7e
wesleyboar added a commit that referenced this issue Jul 9, 2021
@wesleyboar
GH-245/GH-56: Submod: Add small doc
9b0a0ef
wesleyboar added a commit that referenced this issue Jul 12, 2021
@wesleyboar
GH-245/GH-56: Submod: Revert GH-73 commits
7027858
@wesleyboar
Copy link
Member Author

Seems to be working now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wesleyboar wesleyboar

Labels
bug Something isn't working paused Started but not actively in progress priority ▼ Low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wesleyboar