Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce TACC Logo Size #284

Closed
wesleyboar opened this issue Jul 15, 2021 · 0 comments · Fixed by #285
Closed

Reduce TACC Logo Size #284

wesleyboar opened this issue Jul 15, 2021 · 0 comments · Fixed by #285
Labels
effort XS Extra small effort task (~¼ a week) — does not include review time enhancement Improvements or additions to existing features priority ▼▼ Very low priority

Comments

@wesleyboar
Copy link
Member

wesleyboar commented Jul 15, 2021 •
edited
Loading

Goal

Reduce size of TACC image.

Requirements

  1. TACC logo must be only as tall as necessary.*
  2. TACC logo filename should not change (so secrets need not update).
  3. TACC logo original size may be retained as different file name.

* This is the greater of the height of the header old design and new design.

Background

  1. The image has been unnecessarily large since the Core CMS was created.
  2. The issue Facebook Reads TACC Logo When Sharing Links #283 can be solved by this issue.
@wesleyboar wesleyboar added effort XS Extra small effort task (~¼ a week) — does not include review time enhancement Improvements or additions to existing features priority ▼▼ Very low priority labels Jul 15, 2021
This was referenced Jul 15, 2021
Closed
Merged
@wesleyboar wesleyboar linked a pull request Jul 15, 2021 that will close this issue
GH-283/GH-284: Fix Facebook Share Bug (Smaller TACC Logo) #285
Merged
1 task
wesleyboar added a commit that referenced this issue Aug 13, 2021
@wesleyboar
GH-283/GH-284: Update submod (merge main)
df6fdec
wesleyboar added a commit that referenced this issue Oct 18, 2021
@wesleyboar
Quick: v3 Changelog (clearer link to GH-284)
e5dc7b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort XS Extra small effort task (~¼ a week) — does not include review time enhancement Improvements or additions to existing features priority ▼▼ Very low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-283/GH-284: Fix Facebook Share Bug (Smaller TACC Logo) TACC/Core-CMS
1 participant
@wesleyboar