Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish base.html Markup #149

Closed
wesleyboar opened this issue Mar 3, 2021 · 0 comments · Fixed by #151
Closed

Polish base.html Markup #149

wesleyboar opened this issue Mar 3, 2021 · 0 comments · Fixed by #151
Assignees
@wesleyboar
Labels
bug Something isn't working effort XL Extra large effort task (~4 weeks) — does not include review time enhancement Improvements or additions to existing features priority ━ Medium priority

Comments

@wesleyboar
Copy link
Member

wesleyboar commented Mar 3, 2021 •
edited
Loading

Goal

  1. Remove unnecessary ID attribute in base.html.
  2. Update base.html to use semantic markup.
  3. Remove unnecessary div wrap from base.html.
  4. Update project-specific styles/markup as relevant.

Background

  1. The ID was inherited, and is unnecessary if <main> is used (of which there must only be one).
  2. The markup was inherited, and is not semantic.
  3. The base.html has two .o-site__body instances and an excess <div> wrapping the main and footer content.
  4. Some project-specific styles use main and #content-wrap to style (until #content-wrap is replaced).
@wesleyboar wesleyboar changed the title Polish base.html Markup Polish base.html Markup Mar 3, 2021
@wesleyboar wesleyboar added bug Something isn't working effort XL Extra large effort task (~4 weeks) — does not include review time priority ━ Medium priority labels Mar 3, 2021
@wesleyboar wesleyboar self-assigned this Mar 3, 2021
wesleyboar added a commit that referenced this issue Mar 3, 2021
@wesleyboar
Quick: Revert changes to be isolated in GH-149
d6fa896
@wesleyboar wesleyboar mentioned this issue Mar 3, 2021
Closed
wesleyboar added a commit that referenced this issue Mar 3, 2021
@wesleyboar
GH-149: Polish base.html markup
d1db1ee 
1. Remove unnecessary ID attribute.
2. Update markup to be semantic.
3. Remove unnecessary `<div>` wrap.
@wesleyboar wesleyboar mentioned this issue Mar 3, 2021
Merged
wesleyboar added a commit that referenced this issue Mar 24, 2021
@wesleyboar
Merge branch 'main' into task/GH-149-polish-base-html-markup
561d04d
wesleyboar added a commit that referenced this issue Mar 24, 2021
@wesleyboar
Merge branch 'main' into task/GH-149-polish-base-html-markup
5ddb61c
@wesleyboar wesleyboar linked a pull request Apr 6, 2021 that will close this issue
GH-149: Polish base.html markup #151
Merged
wesleyboar added a commit that referenced this issue Apr 22, 2021
@wesleyboar
Merge branch 'main' into task/GH-149-polish-base-html-markup
4d45df5
wesleyboar added a commit that referenced this issue May 10, 2021
@wesleyboar
Merge branch 'main' into task/GH-149-polish-base-html-markup
bcb5909
wesleyboar added a commit that referenced this issue Jun 17, 2021
@wesleyboar
Merge branch 'main' into task/GH-149-polish-base-html-markup
73ebf37
wesleyboar added a commit that referenced this issue Jun 17, 2021
@wesleyboar
GH-149: Update submodule to merge of main
50db29e
wesleyboar added a commit that referenced this issue Jun 19, 2021
@wesleyboar
Merge branch 'main' into task/GH-149-polish-base-html-markup
e391b5c
@wesleyboar wesleyboar added the enhancement Improvements or additions to existing features label Jul 3, 2021
wesleyboar added a commit that referenced this issue Jul 13, 2021
@wesleyboar
Merge branch 'main' into task/GH-149-polish-base-html-markup
7454333
wesleyboar added a commit that referenced this issue Nov 4, 2021
@wesleyboar
Merge branch 'main' into task/GH-149-polish-base-html-markup
0f901f6
wesleyboar added a commit that referenced this issue Mar 10, 2022
@wesleyboar
Merge branch 'main' into task/GH-149-polish-base-html-markup
fdf094b
wesleyboar added a commit that referenced this issue Apr 24, 2022
@wesleyboar
Merge branch 'main' into task/GH-149-polish-base-html-markup
3976e73
wesleyboar added a commit that referenced this issue Apr 24, 2022
@wesleyboar
chore(gh-149): remove comments, tweak whitespace
9efc86a
wesleyboar added a commit that referenced this issue Apr 24, 2022
@wesleyboar
fix(gh-149): restore a deleted id (not the other)
8a133f2
wesleyboar added a commit to TACC/Core-CMS-Resources that referenced this issue Apr 24, 2022
@wesleyboar
GH-149: Updates for TACC/Core-CMS#149 (base.html polish) (#133)
7818020
wesleyboar added a commit that referenced this issue Apr 24, 2022
@wesleyboar
chore(gh-149): update submod & core-styles
595781f
wesleyboar added a commit that referenced this issue Apr 24, 2022
@wesleyboar
GH-149: Polish base.html markup (#151)
7fc6738 
* GH-149: Polish base.html markup

1. Remove unnecessary ID attribute.
2. Update markup to be semantic.
3. Remove unnecessary `<div>` wrap.

* GH-149: Update submodule to merge of main

* chore(gh-149): remove comments, tweak whitespace

* fix(gh-149): restore a deleted id (not the other)

* chore(texascale): remove legacy selectors, id gone

* chore(gh-149): update submod & core-styles

Co-authored-by: W. Bomar <62723358+tacc-wbomar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wesleyboar wesleyboar

Labels
bug Something isn't working effort XL Extra large effort task (~4 weeks) — does not include review time enhancement Improvements or additions to existing features priority ━ Medium priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-149: Polish base.html markup TACC/Core-CMS
1 participant
@wesleyboar