Quick: (UTRC-356) Migrate Banner Overlay Styles to Frontera (from Core) #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> __Warning__: This relies on code from `quick/UTRC-356-add-overlay-mixins`. 1. One banner overlay style was designed for Frontera. 2. That banner overlay style was assumed for TACC. 3. TACC redesign shows banner overlay will not be used on TACC. 4. UTRC hompeage will use a different banner overlay style.
…from-core-to-frontera
This specificty is more for consistency than necessity, because the home page is not likely to have two overlays. But consistent additions seem better than changing existing code.
This was referenced Sep 27, 2021
wesleyboar
changed the title
This was referenced Sep 27, 2021
|
Closing in favor of larger PR #94 (which references this PR in its changeset). |
wesleyboar
deleted the
quick/UTRC-356-migrate-banner-overlay-style-from-core-to-frontera
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Required By
The "parent" PR.
Overview
Migrate CSS for banner overlay styles (which UTRC styles differently) to Frontera from Core.