Updating to match Core CMS settings structure #77
Conversation
xandroc
changed the title
|
Great. I did notice two items:
I have created a PR (targeting your branch) for these changes: #74. Please let me know if I got anything wrong. |
…will provide the redundant values.
Testing a TUP DEV CMS bugfix solution.
…rces into task/FP-1194--assist
There was a problem hiding this comment.
More changes were needed for all sites to work like before. Those changes—old secrets.py values migrated to settings_custom.py—have been done in #74. Please check whether that PR may be merged (to this branch).
Also, questions for new CEP_AUTH_VERIFICATION_ENDPOINT (see review).
| ('style_guide.html', 'Style Guide') | ||
| ) | ||
|
|
||
| CEP_AUTH_VERIFICATION_ENDPOINT='https://dev.cep.tacc.utexas.edu' |
There was a problem hiding this comment.
There was a problem hiding this comment.
Ahh! Great catch, Wes, yes. We should relocate that value into the secrets.py.
This value should reflect the same value as the first entry in ALLOWED_HOSTS for any given machine on the TACC network (dev|pprd|prod.project_domain.tacc.utexas.edu).
There was a problem hiding this comment.
Ideally we'll only have secrets in secrets.py, we'll use settings_custom.py to track custom settings across environments, so each env will have and commit its own settings_custom.py. Camino will load these in a similar way as to how different image tags are loaded on each environment
There was a problem hiding this comment.
Yes, that is the long term plan once we have the CMS settings moved into the Deployments repo and mirroring portals.
That said, it will have to be done in a follow on task/ticket in a subsequent sprint. There are just too many portals currently being deployed (over the next two week) for me to be remotely comfortable with additional changes to the deployment setup at this time, having just gotten everything working cleanly as of Friday (and with there still being several portals we need to roll out these changes onto in order to complete aligning our live sites).
There was a problem hiding this comment.
Thank you, both. All makes sense.
Should not be secret value, but must be until we support per-env settings, which is not immediate.
Based on that understanding, I will remove the CEP_AUTH_VERIFICATION_ENDPOINT from sites updated in #74.
There was a problem hiding this comment.
Ah, I never added it to the other sites. So, I don't need to remove it from them. 😅
For UTRC for main (as of this date) see: - PR #79 - branch `task/FP-1213-utrc-setup`
We added the fix in the base of Core-CMS in PR: TACC/Core-CMS#344
FP-1213: Add UTRC (with FP-1194 setup)
(Assist) Updating to match Core CMS settings structure
|
P.S. Texascale, which needed blog (that was removed from Core), now has blog again (see #75), so this PR does not need more work to ensure Texascale works. |
Just use `BRANDING` for variable.
…typos in the custom settings.
Changing filenames from secrets.py to settings_custom.py so they can be loaded dynamically by core cms without explicit references.
import happens here,
https://github.com/TACC/Core-CMS/blob/task/FP-1194/taccsite_cms/settings.py#L419