Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Texascale Blockquote & Offset Content Plugin Styles #61

Merged
merged 16 commits into from
Sep 30, 2021
Merged

Texascale Blockquote & Offset Content Plugin Styles #61

merged 16 commits into from
Sep 30, 2021

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jul 12, 2021 •
edited
Loading

Required By

Overview

Updates based on Core TACC plugins "Blockquote" and "Offset Content".

Changes

  • Deprecate old styles still used by Texascale.org 2019–2020.

  • Migrate Texascale.org c-offset-content to Core o-offset-content.

  • Add --max-wide-and-below and s-blockquote styles for Texascale.org.

  • (complete changelog)
    • Minor: Move styles for deprecated Bootstrap blockquote plugin.
    • Minor: Preserve deprecated c-offset-content styles.
    • New: Rename tacc.c-offset-content.css to c-offset-content.css.
    • New: Migrate Texascale c-offset-content styles to Core o-offset-content styles.
    • New: Add o-offset-content styles to Texascale.
    • Minor: Use @custom-media as --max-wide-… for 2400px.
    • New: Add s-blockquote styles for Texascale.

Issues & Screenshots & Testing

See:

@wesleyboar wesleyboar mentioned this pull request Jul 12, 2021
Merged
1 task
@wesleyboar wesleyboar changed the title Core-CMS | GH-73: Blockquote, GH-66: Offset Content Plugin GH-73: Blockquote, GH-66: Offset Content Plugin Jul 12, 2021
@wesleyboar wesleyboar mentioned this pull request Aug 26, 2021
Closed
@wesleyboar wesleyboar mentioned this pull request Sep 1, 2021
Draft
7 tasks
@wesleyboar wesleyboar changed the title GH-73: Blockquote, GH-66: Offset Content Plugin Texascale Blockquote & Offset Content Plugin Styles Sep 1, 2021
duckonomy
duckonomy approved these changes Sep 16, 2021
View reviewed changes
Copy link
Collaborator

@duckonomy duckonomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wesleyboar wesleyboar mentioned this pull request Sep 30, 2021
Merged
@wesleyboar wesleyboar merged commit 147ee85 into main Sep 30, 2021
@wesleyboar wesleyboar deleted the task/GH-73-tacc-blockquote-plugin branch September 30, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duckonomy duckonomy duckonomy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wesleyboar @duckonomy