Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick: Add empty Core cms directory #38

Merged
merged 2 commits into from
Apr 6, 2021

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Apr 6, 2021

Dependencies

Overview

Support core-cms as CUSTOM_ASSET_DIR in image build configuration (even if Core has no assets).

This will allow us to combine dockerhub_repo and CUSTOM_ASSET_DIR into one parameter.

Related Tickets

Testing

  1. Build new docker image using core-cms for both.
    • You may use taccwma/core-cms:7d3351b.
  2. Follow Test New CMS Site instructions.
    • If testing on a local standalone CMS, be sure you're on the matching branch for Core-CMS.
  3. (In Step 2 of Test New CMS Site) Set CMS to run as core-cms.
  4. Load a page that uses the Core fullwidth.html template.
  5. Ensure background is white.*†

* If background is not white, and you are testing with local image on local standalone CMS, be sure you run npm run build.
† Because example-cms, previous "Core" build has yellow background.

Resources

  • remote docker image: taccwma/core-cms:7d3351b

@wesleyboar
Copy link
Member Author

wesleyboar commented Apr 6, 2021

I am merging without explicit peer approval, because the parent PR is ready for merge.

@wesleyboar wesleyboar merged commit 6d3ce3c into master Apr 6, 2021
@wesleyboar wesleyboar deleted the quick/add-core-cms-project-assets branch April 6, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant