Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance(ecep): ecep_cms → ecep_assets #321

Merged
merged 2 commits into from
Sep 30, 2024
Merged

enhance(ecep): ecep_cms → ecep_assets #321

merged 2 commits into from
Sep 30, 2024

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Sep 30, 2024 •
edited
Loading

Overview / Changes

Migrate ECEP from complex ecep_cms to simple ecep_assets.

Related

Testing

  1. Open https://ecepalliance.org/.
  2. Compare to https://pprd.ecep.tacc.utexas.edu/.
  3. Verify no branding header.
  4. Verify logo is unchanged and from remote URL.
  5. Verify favicon is unchanged and from remote URL.

UI

Before (Prod) After (Test)
navigation ecep prod nav ecep test nav
news list ecep home news list ecep test news list
news page ecep home news page ecep test news page
members ecep prod members ecep test members
Some pages have such different content, they are difficult to compare.
Before (Prod) After (Test)
home page ecep prod home ecep test home

@wesleyboar wesleyboar changed the title enhance(ecep): from _cms to _assets enhance(ecep): from ecep_cms to ecep_assets Sep 30, 2024
@wesleyboar wesleyboar changed the title enhance(ecep): from ecep_cms to ecep_assets enhance(ecep): ecep_cms ➔ ecep_assets Sep 30, 2024
@wesleyboar wesleyboar changed the title enhance(ecep): ecep_cms ➔ ecep_assets enhance(ecep): ecep_cms → ecep_assets Sep 30, 2024
@wesleyboar
chore(ecep): remove unnecessary CSS
ac08a1a 
No need to hide branding via CS. We now hide via setting —

`PORTAL_BRANDING = False`

— in Core-Portal-Deloyments.
@wesleyboar wesleyboar marked this pull request as ready for review September 30, 2024 23:49
@wesleyboar wesleyboar merged commit 7d8f06d into main Sep 30, 2024
@wesleyboar wesleyboar deleted the enhance/from-ecep-cms-to-assets branch September 30, 2024 23:49
wesleyboar added a commit that referenced this pull request Sep 30, 2024
@wesleyboar
chore(ecep): delete now unnecessary workflow
bd30783 
PR #321 just made this file useless 🙂!
@wesleyboar wesleyboar mentioned this pull request Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar