Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TV3-181 add ptdatax #257

Closed
wants to merge 7 commits into from
Closed

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jan 4, 2024

Overview

Add PTDataX website.

Related

Changes

  • added /ptdatax_cms/

Testing

  1. Build and deploy.
  2. Verify logo is "DATA X" from production site.
  3. Verify favicon is the icon from the logo.
  4. Verify available templates are only "Standard" and "Full Width". (Requires login).
  5. Verify stylesheets use Core-Styles v2.
  6. Verify Portal Nav is present.
  7. Verify Search Bar is not present.

UI

ptdatax

Notes

Ideally, a TACC/Core-CMS-Custom:/ptdatax_cms is not necessary. Because the boilerplate is ridiculous and cumbersome. But without it, and without a CDN, we have no place to host the custom branding… right? Feedback welcome.

@wesleyboar wesleyboar changed the title Feat/tv3 181 add ptdatax feat: TV3-181 add ptdatax Jan 4, 2024
Copy link
Member Author

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much ado about nothing.

Too much boilerplate to just to load favicon and a logo! The images could be available at a public CDN that has Github, like the DemData logo is. E.g.:

https://cdn.jsdelivr.net/gh/TACC/Core-CMS-Custom/ptdatax_cms/src/taccsite_custom/ptdatax_cms/static/ptdatax_cms/img/org_logos/ptdatax_cms.png

@rstijerina
Copy link
Member

Agree, it's a large amount of cruft that we could remove with a cdn. Will mark it higher priority

@wesleyboar wesleyboar closed this Jan 6, 2024
@wesleyboar wesleyboar deleted the feat/TV3-181-add-ptdatax branch January 9, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants