Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Include other-code source-ref in compiler error messages #231

Closed
nachumg opened this issue Nov 26, 2024 · 2 comments
Closed

[FEATURE] Include other-code source-ref in compiler error messages #231

nachumg opened this issue Nov 26, 2024 · 2 comments
Labels
feature New feature or request

Comments

@nachumg
Copy link
Contributor

nachumg commented Nov 26, 2024

Describe the problem/limitation you think should be addressed
The following are error-messages, which only emit the source-ref to the duplicate (error-causing) code. All detected and reported in core/namespace.py

  1. Multiple declarations of type
  2. Multiple declarations of instance
  3. Default property ... was already assigned in this scope

Describe the solution you'd like
Also report the source-ref of the already-existing declaration / property assignment.

Describe alternatives you've considered
None.

Additional context
None.

@amykyta3
Copy link
Member

Thanks for the suggestion.

I am already planning on overhauling the message logging system (#168) and this would be a good feature to include along with that.

@amykyta3 amykyta3 added the feature New feature or request label Nov 28, 2024
@amykyta3 amykyta3 added this to the v2.0.0 milestone Nov 28, 2024
nachumg added a commit to nachumg/systemrdl-compiler that referenced this issue Nov 30, 2024
@amykyta3 amykyta3 removed this from the v2.0.0 milestone Jan 3, 2025
@amykyta3
Copy link
Member

amykyta3 commented Jan 3, 2025

Fixed

@amykyta3 amykyta3 closed this as completed Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants