Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update model I/O functions and documentation #883

Merged
merged 26 commits into from
Dec 22, 2024

Conversation

edkerk
Copy link
Member

@edkerk edkerk commented Oct 19, 2024

Main improvements in this PR:

  • Refactor:

    • Use RAVEN functions readYAMLmodel, writeYAMLmodel and exportForGit, instead of the Human-GEM specific importYaml, exportYaml and exportHumanGEM.
    • Modify increaseHumanGEMVersion, and include a check that Human-GEM.yml and model/tsv files match.
    • Prepare for Human-GEM.txt to show metNames[comps] instead of metIDs.
    • Full round of I/O with Human-GEM.yml using RAVEN 2.10.3. Changes in txt (major, see above), xml and mat (both minor) will appear with next release.
    • Remove duplicate getGenesFromGrRules function, already present in RAVEN.
  • Documentation:

    • Update README.md to reflect changes in model I/O functions, more clearly explain the software requirements and the ability to contribute to development without RAVEN.

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

@edkerk edkerk requested a review from feiranl October 19, 2024 19:48
@edkerk edkerk linked an issue Oct 19, 2024 that may be closed by this pull request
8 tasks
@edkerk edkerk mentioned this pull request Oct 19, 2024
8 tasks
Copy link

github-actions bot commented Oct 28, 2024

This PR has been automatically tested with GH Actions. Here is the output of the MACAW test:

Starting dead-end test...
- Found 1514 dead-end metabolites.
- Found 1319 reactions incapable of sustaining steady-state fluxes in either direction due to these dead-ends.
- Found 1977 reversible reactions that can only carry steady-state fluxes in a single direction due to dead-ends.
Starting duplicate test...
- Skipping redox duplicates because no redox_pairs and/or proton_ids were provided.
- Found 447 reactions that were some type of duplicate:
- 0 were completely identical to at least one other reaction.
- 13 involve the same metabolites but go in the opposite direction or have the opposite reversibility as at least one other reaction.
- 447 involve the same metabolites but with different coefficients as at least one other reaction.

This and a more detailed output from MACAW are also committed to data/macawResults/.

Note: In the case of multiple test runs, this post will be edited.

@SysBioChalmers SysBioChalmers deleted a comment from github-actions bot Oct 28, 2024
@edkerk
Copy link
Member Author

edkerk commented Dec 9, 2024

@feiranl Can you review this PR? If you approve, then a lot of conflicts in other PRs can be resolved.

@feiranl
Copy link
Collaborator

feiranl commented Dec 10, 2024

@edkerk, I noticed this PR includes significant changes to the YAML file. I'm concerned that merging it into the develop branch might cause conflicts and complications with other open PRs. If that is not the case, I can review this PR later today.

@edkerk
Copy link
Member Author

edkerk commented Dec 10, 2024

Almost all YML changes are the removal of empty lines:

      - rxnNotes: ""
      - eccodes: ""
      - references: ""

This should pose very limited if any complications with any open PRs.

@feiranl
Copy link
Collaborator

feiranl commented Dec 10, 2024

Ok, will review this later today.

Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ed, Could you help check this? I am trying to run an import and output cycle, but failed with several error. I am using the RAVEN main branch.

code/io/increaseHumanGEMVersion.m Outdated Show resolved Hide resolved
code/io/increaseHumanGEMVersion.m Show resolved Hide resolved
code/io/increaseHumanGEMVersion.m Outdated Show resolved Hide resolved
@feiranl
Copy link
Collaborator

feiranl commented Dec 16, 2024

@edkerk Could you check this PR, so that we can merge this. There are around 20 PRs waiting to be approved and 20 PRs needs to be done...

until fully merged in new RAVEN release
# Conflicts:
#	data/testResults/README.md
#	model/Human-GEM.yml
#	model/genes.tsv
@feiranl
Copy link
Collaborator

feiranl commented Dec 17, 2024

@edkerk Thank you so much for all the hard work yesterday! Please let me know when this PR is ready for review. I can then do a quick check.😊

@edkerk
Copy link
Member Author

edkerk commented Dec 17, 2024

Ready for review!

Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edkerk I am not able to run the full import/ export cycle, could you fix this?

code/io/increaseHumanGEMVersion.m Show resolved Hide resolved
code/io/increaseHumanGEMVersion.m Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Dec 18, 2024

This PR has been automatically tested with GH Actions. Here is the output of the gene essentiality test:

     cellLine     TP     TN     FP    FN     accuracy    sensitivity    specificity       F1         MCC   
__________ __ ____ __ ___ ________ ___________ ___________ ________ ________

{'DLD1' } 37 2165 62 277 0.86659 0.11783 0.97216 0.17918 0.15306
{'GBM' } 34 2147 65 294 0.85866 0.10366 0.97061 0.15925 0.12869
{'HCT116'} 46 2189 57 305 0.86061 0.13105 0.97462 0.20264 0.18513
{'HELA' } 31 2246 72 249 0.87644 0.11071 0.96894 0.16188 0.12659
{'RPE1' } 15 2186 84 255 0.86654 0.055556 0.963 0.081301 0.029544
{'all' } 7 2386 96 109 0.92109 0.060345 0.96132 0.063927 0.022933

Note: In the case of multiple test runs, this post will be edited.

@edkerk edkerk merged commit 7de6638 into develop Dec 22, 2024
5 of 6 checks passed
@edkerk edkerk deleted the chore/newReleaseFunc branch December 22, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update model files
2 participants