-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update model I/O functions and documentation #883
Conversation
getGenesFromGrRules is already in RAVEN
use RAVEN's generic exportForGit instead
# Conflicts: # data/testResults/README.md
This PR has been automatically tested with GH Actions. Here is the output of the MACAW test: Starting dead-end test... This and a more detailed output from MACAW are also committed to
|
# Conflicts: # data/testResults/README.md
…seFunc # Conflicts: # data/testResults/README.md
@feiranl Can you review this PR? If you approve, then a lot of conflicts in other PRs can be resolved. |
@edkerk, I noticed this PR includes significant changes to the YAML file. I'm concerned that merging it into the develop branch might cause conflicts and complications with other open PRs. If that is not the case, I can review this PR later today. |
Almost all YML changes are the removal of empty lines:
This should pose very limited if any complications with any open PRs. |
Ok, will review this later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ed, Could you help check this? I am trying to run an import and output cycle, but failed with several error. I am using the RAVEN main branch.
@edkerk Could you check this PR, so that we can merge this. There are around 20 PRs waiting to be approved and 20 PRs needs to be done... |
until fully merged in new RAVEN release
# Conflicts: # data/testResults/README.md # model/Human-GEM.yml # model/genes.tsv
@edkerk Thank you so much for all the hard work yesterday! Please let me know when this PR is ready for review. I can then do a quick check.😊 |
Ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edkerk I am not able to run the full import/ export cycle, could you fix this?
This PR has been automatically tested with GH Actions. Here is the output of the gene essentiality test: cellLine TP TN FP FN accuracy sensitivity specificity F1 MCC
|
Main improvements in this PR:
Refactor:
readYAMLmodel
,writeYAMLmodel
andexportForGit
, instead of the Human-GEM specificimportYaml
,exportYaml
andexportHumanGEM
.increaseHumanGEMVersion
, and include a check thatHuman-GEM.yml
andmodel/tsv
files match.Human-GEM.txt
to showmetNames[comps]
instead ofmetIDs
.Human-GEM.yml
using RAVEN 2.10.3. Changes intxt
(major, see above),xml
andmat
(both minor) will appear with next release.getGenesFromGrRules
function, already present in RAVEN.Documentation:
README.md
to reflect changes in model I/O functions, more clearly explain the software requirements and the ability to contribute to development without RAVEN.I hereby confirm that I have:
develop
as a target branch