Fix form key persistence #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noggog
reviewed
Apr 3, 2022
| @@ -440,6 +441,8 @@ FormList GetFormList(string name) | |||
| }) | |||
| .Where(x => x != null) | |||
| .Select(x => x!) | |||
| .GroupBy(x => x.AsLink()) | |||
There was a problem hiding this comment.
Hey! Thanks for the PR!
I think this logic can be simplified to just be:
.Distinct(x => x.FormKey)
And while we're in the area, the
.Where(x => x != null)
.Select(x => x!)
can be simplified to
.NotNull()
Feel free to make the changes yourself, otherwise I'll merge this in the next few days and do the additional tweaks then. Cheers!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
weaponRecordsToPatch could contain duplicate weapons if multiple constructible objects produce the same weapon.
MakeEnchantedWeapon did not provide an editor ID at construction so would not use persistence.
This fixes #96