Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vim: update to v9.1 #6398

Merged
merged 4 commits into from
Jan 19, 2025
Merged

vim: update to v9.1 #6398

merged 4 commits into from
Jan 19, 2025

Conversation

hgy59
Copy link
Contributor

@hgy59 hgy59 commented Jan 17, 2025 •
edited
Loading

Description

Fixes #

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Package update

hgy59 added 3 commits January 17, 2025 20:00
@hgy59
vim: update to v9.1
af1cde7
@hgy59
vim: abandon build with python feature
1a5c927 
- this rarely used feature was already lacking in former release (since we used prebuilt python)
@hgy59
use vim9 as alternate name
db82735 
- avoid hard coded specific version
- use 9 instead of 91 as specific version
hgy59 added a commit to hgy59/spksrc that referenced this pull request Jan 18, 2025
@hgy59
prepare redesign of dependency list
5f0267f 
- some changes taken from PR SynoCommunity#6255 to reduce number of dependent packages
- changes that trigger ffmpeg*
- changes that trigger python311 (except vim, separated in PR SynoCommunity#6398)
@hgy59 hgy59 mentioned this pull request Jan 18, 2025
Merged
6 tasks
@hgy59
Copy link
Contributor Author

hgy59 commented Jan 18, 2025

@Thoma7 There are several reasons to drop the python feature in vim:

  • with the redesing of python packages, the python feature was already missing in Vim v9.0-6 package
  • because it is a build time dependecy only, the python package build does not work (configure --with-python is ignored, because libpython*.so is not found)
  • it would need further effort to use the python feature in vim:
    • it must use python of the python311 package
    • but python in path is python 3.8 of Synology
    • we once had a start script for vim (vim82) to start vim of the SynoCommunity package with UTF8 locale in the environment, but this didn't work as expected and I don't want to reinvent it to set custom path when installed python311 is available
  • nobody missed the python feature so far (I guess it was just my idea to implement all possible features)

hgy59 added a commit that referenced this pull request Jan 18, 2025
@hgy59
prepare redesign of dependency list (#6402)
d92586f 
- some changes taken from PR #6255 to reduce number of dependent packages
- changes that trigger ffmpeg*
- changes that trigger python311 (except vim, separated in PR #6398)
hgy59 added a commit to hgy59/spksrc that referenced this pull request Jan 18, 2025
@hgy59
revert changes in vim
7997a82 
- avoid conflicting changes with SynoCommunity#6398
hgy59 added a commit that referenced this pull request Jan 18, 2025
@hgy59
Redesign dependency-list creation for github prepare action (#6255)
bdc87a5 
* redesign dependency-list creation for github prepare action
- add script to evaluate the dependencies
- use new script in global Makefile for the dependency-list target
- use global Makefile to create dependency-list in prepare.sh
- avoid variables in DEPENDS definitions
- make dependency-list.sh executable

* stockfish-webgui: fix digests

* dependency-list: add python and ffmpeg dependency based on include file

* revert changes in sabnzbd
- avoid conflicting changes with #6366

* revert changes in vim
- avoid conflicting changes with #6398

* revert changes in java-11-openjdk
- avoid conflicting changes with #6394
@hgy59 hgy59 merged commit 02f1e39 into SynoCommunity:master Jan 19, 2025
15 checks passed
@hgy59 hgy59 deleted the update_vim branch January 19, 2025 00:33
@hgy59 hgy59 added the status/published Published and activated (may take up to 48h until visible in DSM package manager) label Jan 19, 2025
@hgy59 hgy59 mentioned this pull request Jan 19, 2025
Merged
6 tasks
@hgy59 hgy59 removed the status/published Published and activated (may take up to 48h until visible in DSM package manager) label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hgy59