Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Radarr to v3 #4276

Merged
merged 8 commits into from
Dec 13, 2020
Merged

Update Radarr to v3 #4276

merged 8 commits into from
Dec 13, 2020

Conversation

mreid-tt
Copy link
Contributor

@mreid-tt mreid-tt commented Nov 30, 2020

With the in app update to version 3.0.0.4204 of Radarr the Synology service startup reports the package launch as failed if updated. This PR corrects the PID file reference allowing the startup to report correctly in the Package Center as well as updates the build to the stable v3.0.0.4204

Motivation: To update Radarr to v3 release and correct service startup on Synology
Linked issues: Fixes issue #3987 and issue #4285, previously identified via #3987 (comment)

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

With the update to version 3.0.0.4204 of Radarr the Synology service startup reports the package launch as failed. Correcting the PID file reference allows the startup to report correctly in the Package Center
@mreid-tt mreid-tt mentioned this pull request Nov 30, 2020
@mreid-tt mreid-tt changed the title Correct Radarr PID for V3 service startup on Synology [WIP] Correct Radarr PID for V3 service startup on Synology Dec 5, 2020
@mreid-tt
Copy link
Contributor Author

mreid-tt commented Dec 5, 2020

Updated with workaround for PID file reference in pre-V3 deployments to reflect the correct status in Package Center. This can be removed when the core package has been upgraded from the v0.2.0.1504 it currently contains.

@mreid-tt mreid-tt changed the title [WIP] Correct Radarr PID for V3 service startup on Synology Correct Radarr PID for V3 service startup on Synology Dec 6, 2020
@publicarray
Copy link
Member

publicarray commented Dec 7, 2020

Thanks for your contribution. Looks good 👍 Could you increase the revision number (SPK_REV = 13) in the Makefile please? and update the change log? Thanks 🙏

@mreid-tt
Copy link
Contributor Author

mreid-tt commented Dec 7, 2020

Hey @publicarray, thanks for the guidance. I've updated the Makefile for both the revision and change log.

@publicarray
Copy link
Member

Hi @houndtt, thanks for the quick update 👍 After reading the initial issue again I realised that the pull request also needs to be updated to radar v3 otherwise users that are already on v3 and install this new revision will downgrade to v2 and possibly mess up their database. Can you make these changes? To update the digests file you can run: make digests

@mreid-tt
Copy link
Contributor Author

mreid-tt commented Dec 9, 2020

Hi @publicarray, I am not a very experienced programmer but I can try. For the scenario you mentioned I did install the existing v2 build in Virtual DSM, upgraded to v3 via the app and then upgraded the package using this build. The interface seemed to stay at the v3 revision and not downgrade to v2 but to be fair I didn't have a library configured so I can't say for sure that database issues would not occur.

Let me see if I can do what you suggest and upgrade Radarr to v3 and get back to you.

@mreid-tt mreid-tt changed the title Correct Radarr PID for V3 service startup on Synology Update Radarr to v3 Dec 9, 2020
@mreid-tt
Copy link
Contributor Author

mreid-tt commented Dec 9, 2020

Hi @publicarray, I've completed the changes to the files for v3.0.0.4204 of Radarr. I drew heavily on the work from @maxrogers (https://github.com/SynoCommunity/spksrc/pull/3803/files) to identify the correct files to modify.

Re-testing in Virtual DSM has been successful for the two upgrade scenarios as well as for a new install. Do let me know if there is anything further that I need to address.

Copy link
Member

@publicarray publicarray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the prompt changes.
Regarding the Please upgrade to the .NET Core version of Radarr I wouldn't worry about it for now. There are plans to add .NET build scripts to spksrc but I'm waiting for them to be reviewed and merged. (#4207)

@mreid-tt
Copy link
Contributor Author

Regarding the Please upgrade to the .NET Core version of Radarr I wouldn't worry about it for now. There are plans to add .NET build scripts to spksrc but I'm waiting for them to be reviewed and merged. (#4207)

I seem to have exhausted my attempts to incorporate this by pulling in the dotnet-core sources directly (#4300). I guess we'll have to wait until your .NET Core build scripts are incorporated.

@publicarray publicarray merged commit e945fcc into SynoCommunity:master Dec 13, 2020
@mreid-tt mreid-tt deleted the patch-1 branch December 13, 2020 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants