-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: OSX #79
CI: OSX #79
Conversation
@casperdcl: Using the Cmake argument, However, Travis is still failing. The error is As far as I can tell from the Travis log, I have no way of telling which library was compiled against the different version of python (if that is the issue...). The branch is here: OSX_abs_paths. |
Thanks for looking into this. It confirms what I had said during the earlier tcons. You can see the mismatched bin and lib versions (2.7.10 and 2.7.14 from what I remember) in the cmake output on travis. What I had requested is help with installing matching bin & lib versions on osx. AFAIK travis doesn't have matched versions. I'm tempted to just go with anaconda... |
Edit: yes just looked at your log, it shows 2.7.14 (bin) and 2.7.10 (lib). Don't recall ever having issues with rpaths/dylibs. |
we've briefly looked at this. we're still using |
Hi all, I've been trying to set one specific version of python. I want to get that to work before going to the general case of letting the user select their python version. I set I also created a variable, However, I'm now getting a strange error during the ctests saying: I've been trying to remedy this by messing around with The branch I'm working on is here. |
Checked the latest travis log. It seems that @rijobro got passed the python/matplotlib problems with the hard-wired path (great, good starting point!). However, now we have
This is essentially the same problem as SyneRBI/SIRF-SuperBuild#63. I believe this needs a SIRF modification to the CMakeLists.txt as in https://stackoverflow.com/questions/35377704/dlopen-error-unsafe-use-of-relative-rpath-on-os-x-el-capitan (although it seems to me that Presumably we would then need a similar modification in ISMRMRD and Gadgetron and STIR... One way to achieve this would be to set these in the SuperBuild.cmake and use (Didn't we have this conversation already?) |
Unfortunately, options such as I managed to avoid the Brew's installation of Boost 1.65 uses rpaths, so caused errors. This can be avoided either by compiling our own version (with Lastly, we had problems of mismatching python versions. I got around this by hard-wiring paths to |
@rijobro, can you merge your SuperBuild changes here to SIRF as well? |
Done, and have pull requested. Travis currently fails because SIRF clones the master SuperBuild which does not have this fix yet. |
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
==========================================
+ Coverage 54.54% 55.51% +0.97%
==========================================
Files 2 2
Lines 1674 1632 -42
==========================================
- Hits 913 906 -7
+ Misses 761 726 -35
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
=======================================
Coverage 54.54% 54.54%
=======================================
Files 2 2
Lines 1674 1674
=======================================
Hits 913 913
Misses 761 761 Continue to review full report at Codecov.
|
@@ -143,12 +181,12 @@ before_install: | |||
- export BUILD_FLAGS="$BUILD_FLAGS -DPYVER=$PYMVER -DSIRF_URL=$PWD -DSIRF_TAG=$TRAVIS_COMMIT" | |||
# get SuperBuild | |||
- cd .. | |||
- git clone https://github.com/CCPPETMR/SIRF-SuperBuild --recursive -b master | |||
- git clone https://github.com/CCPPETMR/SIRF-SuperBuild --recursive -b OSX_abs_paths |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want this? we then will have to remember to remove it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, have it in my local merge, will push when approved
Use numba @jit by default now we're using Py3. Fixes SyneRBI#64
fix travis for osx builds (continues #71)