Zoom image from template method for ImageData

[samdporter]

Changes in this pull request

Added method for ImageData to zoom image using geometrical information from a template image

Testing performed

• Compared ImageData zoomed using zoom_image_from_template() and zoom_image() with manually calculated arguments (although dimensions will be different).
• Compared with zoom_image using stir python

Related issues

Checklist before requesting a review

• I have performed a self-review of my code
• I have added docstrings/doxygen in line with the guidance in the developer guide
• I have implemented unit tests that cover any new or modified functionality
• The code builds and runs on my machine
• CHANGES.md has been updated with any functionality change

Contribution Notes

Please read and adhere to the contribution guidelines.

Please tick the following:

• The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in SIRF (the Work) under the terms and conditions of the Apache-2.0 License.

[KrisThielemans]

some comments, but in addition,

• there are some weird/unnecessary white-space differences. Please fix/ remove (see the diff on github). Some of this might be caused by editor conventions with tabs vs spaces, but even your own code doesn't like sensible in places.

• add a line to CHANGES.md

[samdporter]

Hey Kris,
I think I've corrected all the bits you asked for. zoom_image_as_template is now used across the board and I removed some odd whitespace. The Doxygen comments are only one line but I think it should be sufficient.

Are there any specific unit tests that I should add or is it enough that they (probably) exist in STIR?

[KrisThielemans]

I still see strange inconsistent indentation in the C/C++ files, but as we currently don't have a way to enforce this, I'm prepared to accept it.

[KrisThielemans]

@evgueni-ovtchinnikov want to review?

[KrisThielemans]

@samdporter could conceivably add a Python test (e.g. zoom, test if geometric_info is the same). Not sure how easy it is, and a lot of this is untested anyway, but I'd appreciate it :-)

[evgueni-ovtchinnikov]

please see my comments for cstir.cpp line 1513 and STIR.py line 699

[evgueni-ovtchinnikov]

looks ok

[samdporter]

I was thinking that perhaps zoom_image_to_template makes more sense?

I'll get on the python test next week. Sorry for the delay

[casperdcl]

probably fine to remove this since STIR_REQUIRED_VERSION in cmake is currently 6.0

resolved