Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to ROOT v6-28-12 #859

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

KrisThielemans
Copy link
Member

hopefully fixes #857

@KrisThielemans KrisThielemans added this to the v3.6 milestone Feb 1, 2024
@KrisThielemans
Copy link
Member Author

v6-28-12 compiled TBB ok, but the failed in XROOTD installation. XROOTD-install-err.log says

[I] No git repository info found. Trying to interpret VERSION_INFO
[I] The XrdVersion.hh file already exists
gmake[7]: *** read jobs pipe: Bad file descriptor.  Stop.
gmake[7]: *** Waiting for unfinished jobs....
gmake[6]: *** [Makefile:136: all] Error 2
CMake Error at /home/runner/work/SIRF-SuperBuild/SIRF-SuperBuild/build/builds/ROOT/build/builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-install-Release-impl.cmake:9 (message):
  Command failed (2):

   '/usr/local/bin/cmake' '--build' '.' '--target' 'install'

@KrisThielemans
Copy link
Member Author

Needed more recent `nlohmann/json due to root-project/root#14634

Still stuck due to #861

@KrisThielemans
Copy link
Member Author

Although #857 auto-disappeared (presumably due to a wrong config of the GHA runners), updating ROOT is necessary for C++-17, which will be required for the next STIR version (UCL/STIR#1236 in progress), so best to merge this now.

@KrisThielemans KrisThielemans merged commit 8ca5067 into SyneRBI:master Feb 29, 2024
8 checks passed
@KrisThielemans KrisThielemans deleted the ROOT_v6-28-12 branch February 29, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ROOT TBB build failures on GHA
1 participant