-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version_config.cmake and others files for release #829
Conversation
more CCPi regulariser trouble sadly
Docker builds still stuck due to #826 |
I'm not sure where this bug comes from, it used to work earlier and I am tempted to remove the unit tests for the release and open an issue for next release. I opened an issue on the TomographicImaging/CCPi-Regularisation-Toolkit#177 repo. |
@KrisThielemans @evgueni-ovtchinnikov @casperdcl now that the tests are all green (see 6e0b7e3), I suggest to merge this PR and tag the SuperBuild. We should then tackle #832 in a later release. This PR removes the CCPi Regularisation from the packages built with CIL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
why? I thought you were just going to disable the tests. If you need to disable the build, then #832 needs to be adjusted.
Please merge #830 after this PR. It avoids conflicts for people who have MATLAB installed. |
The unit test fails because of an import error. I didn't understand why this happens in the GitHub runner. I thought to outright remove the software instead of packaging it with potential import errors. |
ok |
updates for release 3.5.0