Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use system boost by default because of #63 #104

Merged
merged 1 commit into from
Mar 26, 2018

Conversation

paskino
Copy link
Contributor

@paskino paskino commented Mar 26, 2018

No description provided.

@rijobro
Copy link
Contributor

rijobro commented Mar 26, 2018

@KrisThielemans - as requested, the info telling Mac users to upgrade to Boost 1.66 is given here. I wonder if it's not in an obvious enough location?

@evgueni-ovtchinnikov evgueni-ovtchinnikov merged commit 8f929a5 into master Mar 26, 2018
@KrisThielemans
Copy link
Member

sorry to be late. I thought we'd only do this for OSX and Windows, but keep it OFF elsewhere. @bathomas, @casperdcl any opinions?

@paskino
Copy link
Contributor Author

paskino commented Mar 26, 2018

No worries. I misunderstood your email.
I'll add a switch if not UNIX

@KrisThielemans
Copy link
Member

@rijobro we'll now require it, so it needs to be moved up to "requirements". sorry

@bathomas
Copy link
Contributor

Seems unnecessary to default to ON for an OS that doesn't have a problem. SIRF(-SuperBuild) is straightforward to use on Ubuntu. Also, the packaged version would be older (1.54?) on Travis.

@paskino
Copy link
Contributor Author

paskino commented Mar 26, 2018

The Superbuild is actually building Boost 1.63. Wouldn't it be sufficient to upgrade the built (required) version to 1.66?

@rijobro
Copy link
Contributor

rijobro commented Mar 26, 2018

It wouldn't be sufficient - Brew's version of 1.66 solves the problem on OSX (thus why USE_SYSTEM_Boost works).

But the problem is still there with the boostrapped version 1.66 of boost (the one that will be installed by the superbuild).

@bathomas
Copy link
Contributor

As @KrisThielemans said, I think USE_SYSTEM_Boost should be OFF for Linux systems and ON for the others.

@paskino
Copy link
Contributor Author

paskino commented Mar 26, 2018

OK, then I'll add the switch for non Unix.
Can we fix our own compilation of Boost on MacOSX?

@rijobro
Copy link
Contributor

rijobro commented Mar 26, 2018

I looked into this before. We install Boost with ./bootsrap.sh and then ./b2 install, so in one of those two we would have to add an option that would install the absolute paths to the dynamic libraries. So far, I haven't found a way of doing that.

@rijobro
Copy link
Contributor

rijobro commented Mar 26, 2018

Or maybe, add the switch if OSX in CMake, and build Boost with static libs if true?

@paskino
Copy link
Contributor Author

paskino commented Mar 26, 2018

To be clear, on OSX the only way to have the SuperBuild working is to install Boost 1.66 with brew

@paskino
Copy link
Contributor Author

paskino commented Mar 26, 2018

@rijobro what about this and this and especially hardcode-dll-paths=true dll-path=/custom/path/lib

@rijobro
Copy link
Contributor

rijobro commented Mar 26, 2018

I tried that before with no luck (might be out of date). I'll try again and let you know.

@rijobro
Copy link
Contributor

rijobro commented Mar 26, 2018

Tried again with no effect (maybe outdated?)

paskino pushed a commit to paskino/SIRF-SuperBuild that referenced this pull request Oct 25, 2021
* additional packages for ubuntu18.04

* add path to local user binary directory

* Added vagrantfile for 18.04

* use ubuntu18.04 branch of SIRF-SuperBuild

* remove install of gcc 6

* updates

* remove checkout of ubuntu18.04 SIF-SuperBuild tag

* Use system boost

* use bento box

* Added 50Gb VDI disk image

https://www.virtualbox.org/manual/ch05.html

* builds VM with vagrant

currently doesn't find the system Boost.

* add port forwarding, add 32 Mb video ram, 50 Gb HDD

* use system boost

* delete sirf_disk.vdi

* removed links to specific VM and SuperBuild branches

requires SyneRBI#149 first

* use globbing for resetting *URL and *TAG

* set USE_ITK=ON

* created function find_boost_version

* moved shell provision script to file

closes SyneRBI#114

* install libhdf5-dev

* vram is in modifyvm section

https://www.virtualbox.org/manual/ch08.html

* indentation fix

* removed comment

* separate the install steps

* multi line install

* added bootstrap_ubuntu.sh script

* install missing boost libraries

* removes autosuspend notification

closes SyneRBI#118

* add info on 2.0rc1

* builds ubuntu18.04 SuperBuild

* build ubuntu18.04 branch of superbuild

* removed conflict message

* changed VM name

* uses SuperBuild master

* removed -V command

* checks if user and homedir is already created

* bugfix

* bugfix~~

* fix test dir existence

* install spyder and jupyter in pip script

* force spyder 3.2

* manual configure jupyter

* info on manual step to configure ip for jupyter

* add info on jupyter config

* removed reference to specific branches

* updated VM name

* add new version

* update doc

* clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants