Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check new support for package_ROOT in CMake, in particular for BOOST #153

Open
KrisThielemans opened this issue Nov 6, 2018 · 1 comment
Open

check new support for package_ROOT in CMake, in particular for BOOST #153

KrisThielemans opened this issue Nov 6, 2018 · 1 comment
Assignees
@paskino
Milestone
v4.0

Comments

@KrisThielemans
Copy link
Member

See UCL/STIR#286.
@KrisThielemans KrisThielemans mentioned this issue Nov 6, 2018
Closed
@KrisThielemans KrisThielemans mentioned this issue Jan 24, 2019
Open
@KrisThielemans KrisThielemans added this to the v2.1 milestone Feb 15, 2019
@KrisThielemans KrisThielemans modified the milestones: v2.1, v2.2 Oct 6, 2019
@KrisThielemans KrisThielemans modified the milestones: v3.0, v3.1 Mar 11, 2021
paskino added a commit to paskino/SIRF-SuperBuild that referenced this issue Oct 25, 2021
@paskino
remove explicit pull
09b35c5 
removes explicit pull. see also SyneRBI#153
paskino added a commit to paskino/SIRF-SuperBuild that referenced this issue Oct 25, 2021
@paskino @KrisThielemans
adds pull after fetch
a981de4 
addresses SyneRBI#153
paskino pushed a commit to paskino/SIRF-SuperBuild that referenced this issue Oct 25, 2021
@KrisThielemans
fix pull behaviour for local branches
e5ce8dd 
Fixes SyneRBI#153
paskino pushed a commit to paskino/SIRF-SuperBuild that referenced this issue Oct 25, 2021
@KrisThielemans
Merge pull request SyneRBI#155 from SyneRBI/add_pull
c1993ad 
change behaviour of fetch/pull with tags

fixes SyneRBI#153
@KrisThielemans
Copy link
Member Author

Required change is just

if(POLICY CMP0074)
  cmake_policy(SET CMP0074 NEW) # find_package() uses <PackageName>_ROOT variables
endif()

@paskino, feel free to do this or postpone to 3.5 as this doesn't break anything.

@paskino paskino modified the milestones: v3.4, v3.5 Jan 19, 2023
@KrisThielemans KrisThielemans modified the milestones: v3.5, v4.0 Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paskino paskino

Labels
None yet
Projects
None yet
Milestone
v4.0
Development

No branches or pull requests
2 participants
@KrisThielemans @paskino