Skip to content

Commit

Permalink
[CMAKE] default DISABLE_MATLAB to ON
Browse files Browse the repository at this point in the history
SIRF Matlab support is out-of-date and could generate conflicts with Python shared libraries.
  • Loading branch information
KrisThielemans committed Aug 13, 2023
1 parent bfc474a commit 5e30250
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 4 additions & 1 deletion CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## v3.5.0
- Temporarily disable CCPi-Regularisation due to #832
- CMake/building:
- default `DISABLE_MATLAB` to `ON` as SIRF Matlab support is out-of-date and enabling it could
generate conflicts with Python shared libraries.
- docker image updates
- introduce `REMOVE_BUILD_FILES` variable. If set to 1 (which is the default),
most build files will be removed in the docker image.
Expand All @@ -11,7 +14,7 @@
- Installing requirements for SIRF-Exercises uses its environment.yml or requirements.txt depending on settings.
- Build Gadgetron master. Requires new Ubuntu packages: libdcmtk-dev, libpugixml-dev, libgflags-dev,
libssl-dev, libcurl4-openssl-dev, pkg-config, golang, libboost-coroutine-dev, libboost-context-dev, libboost-random-dev.
- Added SuperBuild project dependency: range-v3, RocksDB, Date, mrd-storage-server
- Added SuperBuild project dependencies for Gadgetron: range-v3, RocksDB, Date, mrd-storage-server
- updated versions:
- Gadgetron: 42f11bf14b77b16f1ca5bcfbfa435d5ee8cb22a6 (master)
- RocksDB: 6.26.0
Expand Down
2 changes: 1 addition & 1 deletion SuperBuild.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ else()
endif()

#### MATLAB support
option(DISABLE_Matlab "Disable building MATLAB support" OFF)
option(DISABLE_Matlab "Disable building MATLAB support" ON)
if (DISABLE_Matlab)
message(STATUS "Matlab support disabled")
else()
Expand Down

0 comments on commit 5e30250

Please sign in to comment.