-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(precompile programs): ed25519 verify #575
Conversation
5ed5403
to
7c4e9cb
Compare
Codecov ReportAttention: Patch coverage is
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you stick to using RLS for all of the struct initializations? Right now it's kinda half RLS half T{}
.
The logic itself looks good, just some comments about different things :).
e25af20
to
387a166
Compare
I recommend you remove the unimplemented programs, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm just need to pass code-cov
Decided to split the three programs into multiple PRs.