Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(precompile programs): ed25519 verify #575

Merged
merged 16 commits into from
Feb 28, 2025
Merged

Conversation

Sobeston
Copy link
Contributor

@Sobeston Sobeston commented Feb 24, 2025

Decided to split the three programs into multiple PRs.

@Sobeston Sobeston force-pushed the sobe/precompile-program-2 branch 2 times, most recently from 5ed5403 to 7c4e9cb Compare February 24, 2025 20:48
@Rexicon226 Rexicon226 self-requested a review February 24, 2025 21:52
@Sobeston Sobeston changed the title feat(precompile program) feat(precompile programs): ed25519 verify Feb 25, 2025
@Sobeston Sobeston marked this pull request as ready for review February 25, 2025 04:27
@Sobeston Sobeston requested a review from yewman February 25, 2025 04:28
Copy link
Contributor Author

Sobeston commented Feb 25, 2025

Copy link
Contributor

@Rexicon226 Rexicon226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you stick to using RLS for all of the struct initializations? Right now it's kinda half RLS half T{}.

The logic itself looks good, just some comments about different things :).

@Sobeston Sobeston requested a review from Rexicon226 February 25, 2025 22:45
@Sobeston Sobeston force-pushed the sobe/precompile-program-2 branch from e25af20 to 387a166 Compare February 26, 2025 17:51
@Sobeston Sobeston requested a review from 0xNineteen February 26, 2025 23:45
@Rexicon226
Copy link
Contributor

I recommend you remove the unimplemented programs, secp256{k1,r1} and add them back in the next PR. That'll pass the coverage, and make the changeset more atomic.

0xNineteen
0xNineteen previously approved these changes Feb 27, 2025
Copy link
Contributor

@0xNineteen 0xNineteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just need to pass code-cov

@Sobeston Sobeston added this pull request to the merge queue Feb 28, 2025
Merged via the queue into main with commit c2f4cd1 Feb 28, 2025
17 checks passed
@Sobeston Sobeston deleted the sobe/precompile-program-2 branch February 28, 2025 05:41
github-merge-queue bot pushed a commit that referenced this pull request Mar 4, 2025
Co-authored-by: x19 <100000306+0xNineteen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants