refactor(ledger): remove manual leak detection in ledger tests #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnut
approved these changes
Oct 7, 2024
Rexicon226
reviewed
Oct 7, 2024
| @@ -1126,14 +1126,14 @@ const ShredInserterTestState = struct { | |||
| db: BlockstoreDB, | |||
| inserter: ShredInserter, | |||
|
|
|||
| pub fn init(comptime test_name: []const u8) !ShredInserterTestState { | |||
| return initWithLogger(test_name, sig.trace.TestLogger.default.logger()); | |||
| pub fn init(allocator_: std.mem.Allocator, comptime test_name: []const u8) !ShredInserterTestState { | |||
There was a problem hiding this comment.
Surely we could think up a better name here. Why wasn't this just called allocator or gpa?
0xNineteen
pushed a commit
that referenced
this pull request
Oct 9, 2024
This PR removes the hardcoded gpa, with manual leak detection from the TestState used in tests. I believe the reason for this was to have more stack trace frames than what the std.testing.allocator offers, but this proved problematic when using the TestingState in other contexts like benchmarking. See #275 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the hardcoded gpa, with manual leak detection from the
TestStateused in tests.I believe the reason for this was to have more stack trace frames than what the
std.testing.allocatoroffers, but this proved problematic when using the TestingState in other contexts like benchmarking.See #275 (comment)