Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing return types for Symfony 6 support #76

Merged
merged 2 commits into from
Aug 27, 2021
Merged

add missing return types for Symfony 6 support #76

merged 2 commits into from
Aug 27, 2021

Conversation

jrushlow
Copy link
Collaborator

No description provided.

@jrushlow jrushlow changed the title [tests] add missing return types add missing return types for Symfony 6 support Aug 27, 2021
@jrushlow
Copy link
Collaborator Author

Failing 5.x 7.4 test is related to upstream PHP Unit method signature changes which have already been fixed. https://github.com/sebastianbergmann/php-file-iterator/blob/156ed6430d56cd26cb0601c8f54b17a022a6a3a7/src/Iterator.php#L45

@jrushlow jrushlow merged commit b8493ec into SymfonyCasts:main Aug 27, 2021
@jrushlow jrushlow deleted the ci/fix-return-types branch August 27, 2021 13:17
@jrushlow jrushlow mentioned this pull request Aug 27, 2021
Merged
weaverryan added a commit that referenced this pull request Nov 19, 2021
@weaverryan
feature #78 [release] update changelog for 1.6.0 (jrushlow)
184599f 
This PR was merged into the main branch.

Discussion
----------

[release] update changelog for 1.6.0

### Feature

- [#76](#76) - add missing return types for Symfony 6 support - *`@jrushlow`*

Commits
-------

48f7855 [release] update changelog for 1.6.0
@jrushlow jrushlow mentioned this pull request Nov 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jrushlow