Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add German translations #52

Merged
merged 2 commits into from
Jan 20, 2021

Conversation

OskarStark
Copy link
Contributor

cc @xabbuh

<body>
<trans-unit id="1">
<source>%count% year|%count% years</source>
<target>%count% Jahr|%count% Jahren</target>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which context is this used? Depending on that %count% Jahre may be correct as well.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applies below as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2021-01-20 at 11 42 12

In the confirmation email

Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @OskarStark for the new translations!

@weaverryan
Copy link
Contributor

Thanks everyone!

@weaverryan weaverryan merged commit 8d192f3 into SymfonyCasts:master Jan 20, 2021
@OskarStark OskarStark deleted the feature/translations-de branch January 20, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants