Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow symfony/twig-bundle ^5.4 to better test lowest deps #8

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

bocharsky-bw
Copy link
Member

@bocharsky-bw bocharsky-bw commented Sep 13, 2023

In order to prevent regression and catch #5 with tests... needed to be rebased on #7 to make tests pass.

Seems we also need to add "symfony/options-resolver": "^5.4|^6.3|^7.0" to the dev deps to fix deprecations

@weaverryan
Copy link
Contributor

Thanks for this Victor - you're totally right we need to make sure 5.4 is actually being tested.

Can you rebase now that #7 is merged? Then we can see if things are passing

Seems we also need to add "symfony/options-resolver": "^5.4|^6.3|^7.0" to the dev deps to fix deprecations

Yea, I think I see them - under Remaining indirect deprecation notices (7) - I'm not sure if those are actually a problem and will make the tests fail. But if they do, sure, we should add this line to fix them.

@bocharsky-bw
Copy link
Member Author

@weaverryan as you can see deprecations cause builds to fail, so I added that symfony/options-resolver dep too. Now all green :)

@weaverryan
Copy link
Contributor

Thanks Victor!

@weaverryan weaverryan merged commit e50c06f into main Oct 9, 2023
4 checks passed
@bocharsky-bw bocharsky-bw deleted the bocharsky-bw-patch-1 branch October 10, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants