-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package and deploy the extension #13
Conversation
|
||
sphinx | ||
symbolator | ||
sphinxcontrib-verilog-diagrams |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should reference the local package, otherwise it will be downloaded from PyPi?
sphinxcontrib-verilog-diagrams | |
-e ../ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is about sphinxcontrib-verilog-diagrams
not about sphinx-verilog-domain
.
Nevertheless, the relative dependencies are not handled properly by conda. If you add the -e ../
to the requirements file, the main environment (created by make-env) will not be created. Conda seems to handle relative dependencies in the requirements file, as a relative to the environment.yml not to the requirements file itself:
Pip subprocess error:
ERROR: File "setup.py" not found. Directory cannot be installed in editable mode: /mnt/hdd1//verilog_domain_ws
The repository is placed in:
/mnt/hdd1/verilog_domain_ws/sphinx-verilog-domain
The sphinx-verilog-domain
package is installed in the environment.yml
directly.
Since the RTD build also uses conda and the documentation build should happen inside this environment, I think that the -e ../
can be omitted in the docs/requirements.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mithro do you agree to left those files in that way? The problem with this convention will never occur unless somebody will decide to build the documentation without using make-env
for this repository. This is exactly the same way as it is done for sphinxcontrib-verilog-diagrams
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rw1nkler - I was sure that I had solved this somewhere...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a bunch of discussion at pypa/pip#328
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that this problem is not resolved for the requirements.txt
(It will be fixed by the pipfile):
- Requirements file which contains
-e
with a relative local path, is only installable from a specific directory pypa/pip#6112 - Requirements 2.0 pypa/pip#1795
As I said before, the problem with the current settings will happen only if somebody will build the docs outside the make-env environment, which is generally wrong. I think that we should leave the requirements file as they are now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment.
Poke me after merging and I'll add the token needed to upload to PyPi.
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
@mithro It seems that the problem with the editable packages installed within nested |
@mithro Can we merge this PR? |
This PR creates the package with the
sphinx-verilog-domain
and adds the ability to deploy it to PyPI using Travis CI.Additionally, the following changes were introduced:
The PR requires proper token setup for PyPI
Resolves #6