Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update slack api endpoints to remove depreciated channels.* methods #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexeiser
Copy link

@alexeiser
Copy link
Author

alexeiser commented Jun 11, 2020

NOTE: that newer slack apps - can not use the post as bot feature from this repo. This means that messages are posted as the user who created/added the app - and not as channel_reaper. While https://github.com/gareth-sharpe/slack-autoarchive makes an attempt at migrating to a bot only flow - the implementation has small issues (mostly because a user auth token is no longer needed at all)

@budbach
Copy link

budbach commented Aug 18, 2020

@alexeiser This is sorely needed but without handling pagination (https://api.slack.com/docs/pagination), the implementation of get_all_channels() will be pretty broken I think. By default, https://slack.com/api/conversations.list returns only the first 100 items (https://api.slack.com/methods/conversations.list).

@alexeiser
Copy link
Author

@alexeiser This is sorely needed but without handling pagination (https://api.slack.com/docs/pagination), the implementation of get_all_channels() will be pretty broken I think. By default, https://slack.com/api/conversations.list returns only the first 100 items (https://api.slack.com/methods/conversations.list).

Agreed - and I borrowed #42 to use on my branch of this repo.

@egeland
Copy link

egeland commented Jan 14, 2021

February 2021 is getting really close... any plans to merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants