Add originalPrice to product response #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
feature/original-price
branch
3 times, most recently
from
7bac34c
to
4f2ec7b
Compare
mamazu
reviewed
Jul 30, 2019
alexander-schranz
force-pushed
the
feature/original-price
branch
from
4f2ec7b
to
93c5282
Compare
mamazu
approved these changes
Jul 30, 2019
mamazu
reviewed
Jul 30, 2019
|
Thank you, Alexander! 🎉 |
lchrusciel
reviewed
Aug 9, 2019
| @@ -33,6 +33,10 @@ | |||
| "current": 1999, | |||
| "currency": "GBP" | |||
| }, | |||
| "originalPrice": { | |||
| "current": 2999, | |||
| "currency": "GBP" | |||
There was a problem hiding this comment.
Is there any possibility to add original price in a different currency than the current one? What would you say, about merging these originalPrice and price fields?
There was a problem hiding this comment.
I think both should be used with the same structure. The price is renderd using a Priceview so should the original price be otherwise it would make things more difficult when consuming this API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the originalPrice is a information which is also mostly needed when reading products.