-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add originalPrice to product response #502
Add originalPrice to product response #502
Conversation
7bac34c
to
4f2ec7b
Compare
4f2ec7b
to
93c5282
Compare
Thank you, Alexander! 🎉 |
@@ -33,6 +33,10 @@ | |||
"current": 1999, | |||
"currency": "GBP" | |||
}, | |||
"originalPrice": { | |||
"current": 2999, | |||
"currency": "GBP" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any possibility to add original price in a different currency than the current one? What would you say, about merging these originalPrice
and price
fields?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think both should be used with the same structure. The price is renderd using a Priceview
so should the original price be otherwise it would make things more difficult when consuming this API.
I think the originalPrice is a information which is also mostly needed when reading products.