Changing the config key as suggested by pamil #190 #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamazu
changed the title
mamazu
changed the title
|
Fixing #263, probably we should document some UPGRADE.md file |
|
Also, it should be adjusted at least here |
lchrusciel
approved these changes
Mar 20, 2019
lchrusciel
approved these changes
Mar 20, 2019
But for which version? |
|
We need to create a new record in https://github.com/Sylius/ShopApiPlugin/blob/master/UPGRADE.md, and notice all the changes, that are BC-Breaks. Problem is that we are over 200 commits from the last release. Nevertheless, some changes that are pretty straightforward to describe. (just to keep a track #340) |
|
Can you generate a list of all the commit messages and I will try to craft a |
lchrusciel
approved these changes
Mar 22, 2019
| @@ -1,3 +1,6 @@ | |||
| # UPGRADE FROM 1.0.0-beta.18 to 1.0.0-beta.20 | |||
There was a problem hiding this comment.
Suggested change
| # UPGRADE FROM 1.0.0-beta.18 to 1.0.0-beta.20 | |
| # UPGRADE FROM 1.0.0-beta.21 to 1.0.0-beta.22 |
|
Thank you, @mamazu! 🎉 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS IS A BC BREAK and needs to be documented. (How?)